config: enable user configuration for retry strategy. #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smityz <[email protected]>
Signed-off-by: Smityz <[email protected]>
disksing
approved these changes
Nov 14, 2023
|
Thanks @Smityz |
|
After this PR, two duplicate files of backoff.go exist: config/retry/backoff.go and internal/client/retry/backoff.go. What is the purpose of maintaining two copies? Is it possible to eliminate one of them? |
I'm sorry, I don't understand the difference between them. If a refactoring is needed, I am also willing to take this job |
|
I'm just wondering why this PR both
If this is by mistake, we can eliminate one of them |
Yes, it's a mistake. I will raise another PR to fix it. Thanks for your reminding |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed that in some cases, the configuration of backoff has a significant impact on the delay. Therefore, we would like to provide the option for manual adjustment of the retry strategy on the client-side.
This PR moved folder
internal/retrytoconfig/retry