make ContainsByEnd return true when the key is empty and region's right bound is inf
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hillium <[email protected]>
|
/cc @disksing |
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
|
I think you're right, but I need to check all usages of this function to prevent this modification from accidentally breaking something. |
disksing
reviewed
Nov 9, 2023
checked, it should be fine. |
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
disksing
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hillium [email protected]
Ref: #1051
I think the semantic of
ContainsByEndshould be: "Please check whether this key is in the range, if the input is empty, treat it as infinity.". But I have noticed there are already some test cases that believes "" shouldn't be in ("", ""]. I'm not sure whether it is by design.Anyway this will bring unexpected behavior sometimes (say, make infinity loops), I think perhaps we can make it better.