-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collecting the RU information by pasing point through context.Value #1032
Merged
iosmanthus
merged 6 commits into
tikv:cse-region-client
from
zeminzhou:context-ru-key-cse5
Nov 6, 2023
Merged
collecting the RU information by pasing point through context.Value #1032
iosmanthus
merged 6 commits into
tikv:cse-region-client
from
zeminzhou:context-ru-key-cse5
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zzm <[email protected]>
Signed-off-by: zzm <[email protected]>
Signed-off-by: zzm <[email protected]>
Signed-off-by: zzm <[email protected]>
Signed-off-by: zzm <[email protected]>
zeminzhou
changed the title
show RU consumption in stmtment log
collecting the RU information by pasing point through context.Value
Oct 27, 2023
Signed-off-by: zzm <[email protected]>
ystaticy
reviewed
Oct 27, 2023
@@ -695,44 +687,6 @@ func (s *KVStore) updateSafeTS(ctx context.Context) { | |||
wg.Wait() | |||
} | |||
|
|||
func (s *KVStore) ruRuntimeStatsMapCleaner() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove those code?
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Nov 21, 2023
…ikv#1032) * ru detail Signed-off-by: zzm <[email protected]> * remove unused code Signed-off-by: zzm <[email protected]> * reduce waitgroup Signed-off-by: zzm <[email protected]> * fix ut Signed-off-by: zzm <[email protected]> * make lint Signed-off-by: zzm <[email protected]> * fix ci Signed-off-by: zzm <[email protected]> --------- Signed-off-by: zzm <[email protected]>
iosmanthus
pushed a commit
that referenced
this pull request
Nov 21, 2023
* collecting the RU information by pasing point through context.Value (#1032) * ru detail Signed-off-by: zzm <[email protected]> * remove unused code Signed-off-by: zzm <[email protected]> * reduce waitgroup Signed-off-by: zzm <[email protected]> * fix ut Signed-off-by: zzm <[email protected]> * make lint Signed-off-by: zzm <[email protected]> * fix ci Signed-off-by: zzm <[email protected]> --------- Signed-off-by: zzm <[email protected]> * don't change compatibility test Signed-off-by: zzm <[email protected]> --------- Signed-off-by: zzm <[email protected]>
glorv
pushed a commit
to glorv/client-go
that referenced
this pull request
Dec 4, 2023
bufferflies
pushed a commit
that referenced
this pull request
Dec 4, 2023
* collecting the RU information by pasing point through context.Value (#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]>
iosmanthus
pushed a commit
to iosmanthus/client-go
that referenced
this pull request
Dec 21, 2023
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]>
nolouch
pushed a commit
to nolouch/client-go
that referenced
this pull request
Feb 2, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]>
glorv
added a commit
that referenced
this pull request
Feb 18, 2024
…#1151) * resource_control: add ru details in ExecDetails (#1070) * collecting the RU information by pasing point through context.Value (#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> * use latest pd-client of release-7.5 Signed-off-by: nolouch <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Signed-off-by: nolouch <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
) (tikv#1151) * resource_control: add ru details in ExecDetails (tikv#1070) * collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> * use latest pd-client of release-7.5 Signed-off-by: nolouch <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Signed-off-by: nolouch <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: zzm <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]> Signed-off-by: zzm <[email protected]>
zeminzhou
added a commit
to zeminzhou/client-go
that referenced
this pull request
Mar 13, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032) Signed-off-by: zzm <[email protected]> * add ruWaitDuration to RUDetails and update pd-client Signed-off-by: glorv <[email protected]> --------- Signed-off-by: zzm <[email protected]> Signed-off-by: glorv <[email protected]> Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To collect all query RU consumption into statement log, ref https://github.com/tidbcloud/tidb-cse/pull/678