bugfix: fix invalid nil pointer when trying to record Store.SlownessStat. #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tat. Signed-off-by: lucasliang <[email protected]>
|
/cc @cfzjywxk PTAL. |
Signed-off-by: lucasliang <[email protected]>
|
/run test |
|
/test |
|
Why the DCO stucks.. |
Signed-off-by: lucasliang <[email protected]>
...It's successful again after I just pick one new tiny pr... |
|
@LykxSassinator Please also update the dependency in mod of tidb repo. |
This was referenced Oct 31, 2023
crazycs520
pushed a commit
to crazycs520/client-go
that referenced
this pull request
Dec 8, 2023
…tat. (tikv#1017) * bugfix: fix invalid nil pointer when trying to record Store.SlownessStat. Signed-off-by: lucasliang <[email protected]> * Polish codes. Signed-off-by: lucasliang <[email protected]> * Polish comments. Signed-off-by: lucasliang <[email protected]> --------- Signed-off-by: lucasliang <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Dec 8, 2023
…tat. (#1017) (#1074) * bugfix: fix invalid nil pointer when trying to record Store.SlownessStat. * Polish codes. * Polish comments. --------- Signed-off-by: lucasliang <[email protected]> Co-authored-by: lucasliang <[email protected]>
iosmanthus
added a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zzm <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: 3pointer <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: crazycs520 <[email protected]> Co-authored-by: Smilencer <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: zyguan <[email protected]> Co-authored-by: Jack Yu <[email protected]> Co-authored-by: Weizhen Wang <[email protected]> Co-authored-by: lucasliang <[email protected]> Co-authored-by: healthwaite <[email protected]> Co-authored-by: xufei <[email protected]> Co-authored-by: JmPotato <[email protected]> Co-authored-by: ekexium <[email protected]> Co-authored-by: 山岚 <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> resolve locks interface for tidb gc_worker (#945) fix some issues of replica selector (#910) (#942) fix some issues of replica selector (#910) fix issue of configure kv timeout not work when disable batch client (#980) fix batch-client wait too long and add some metrics (#973) fix batch-client wait too long and add some metrics (#973)" (#984) fix data race at the aggressiveLockingDirty (#913) fix MinSafeTS might be set to MaxUint64 permanently (#994) fix: fix invalid nil pointer when trying to record Store.SlownessStat. (#1017) Fix batch client batchSendLoop panic (#1021) fix request source tag unset (#1025) Fix comment of `SuspendTime` (#1057)
ti-chi-bot
added
needs-cherry-pick-release-7.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is a bugfix pr, used to fix the
panicissue when trying to record Store.SlownessStat ifrpcCtx.Store == nil.Related issue: pingcap/tidb#47531