add retry limit for excluded backoff type to avoid infinite retry #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @crazycs520 |
zyguan
approved these changes
Oct 11, 2023
ekexium
approved these changes
Oct 11, 2023
| maxBackoffTimeExceeded := (b.totalSleep - b.excludedSleep) >= b.maxSleep | ||
| maxExcludedTimeExceeded := false | ||
| if maxLimit, ok := isSleepExcluded[cfg.name]; ok { | ||
| maxExcludedTimeExceeded = b.excludedSleep >= maxLimit && b.excludedSleep >= b.maxSleep |
There was a problem hiding this comment.
From the name maxLimit, I would suppose the latter part is not necessary. In practice it won't make big difference though.
There was a problem hiding this comment.
In normal circumstances, this check at the end is not necessary. It's mainly to guard against some erroneous inputs or configurations.
crazycs520
reviewed
Oct 11, 2023
internal/retry/backoff.go
Outdated
| @@ -163,7 +169,8 @@ func (b *Backoffer) BackoffWithCfgAndMaxSleep(cfg *Config, maxSleepMs int, err e | |||
| backoffDetail.WriteString(":") | |||
| backoffDetail.WriteString(strconv.Itoa(times)) | |||
| } | |||
| errMsg += fmt.Sprintf("\ntotal-backoff-times: %v, backoff-detail: %v", totalTimes, backoffDetail.String()) | |||
| errMsg += fmt.Sprintf("\ntotal-backoff-times: %v, backoff-detail: %v, maxBackoffTimeExceeded: %v, maxBackoffTimeExceeded: %v", | |||
There was a problem hiding this comment.
Suggested change
| errMsg += fmt.Sprintf("\ntotal-backoff-times: %v, backoff-detail: %v, maxBackoffTimeExceeded: %v, maxBackoffTimeExceeded: %v", | |
| errMsg += fmt.Sprintf("\ntotal-backoff-times: %v, backoff-detail: %v, maxBackoffTimeExceeded: %v, maxExcludedTimeExceeded: %v", |
jackysp
reviewed
Oct 11, 2023
| var isSleepExcluded = map[string]struct{}{ | ||
| BoTiKVServerBusy.name: {}, | ||
| var isSleepExcluded = map[string]int{ | ||
| BoTiKVServerBusy.name: 600000, // The max excluded limit is 10min. |
There was a problem hiding this comment.
It's a bit too far to add a new limit of it, I'm afraid that someday it will be required to be configurable. 😅
There was a problem hiding this comment.
This could only be used in some extreme cases like the service is unavailable but the leader is still valid.
Signed-off-by: cfzjywxk <[email protected]>
Signed-off-by: cfzjywxk <[email protected]>
cfzjywxk
force-pushed
the
add_excluded_type_limit
branch
from
7caa1fe to
74d25c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1001
Try to add retry limit for excluded backoff type to avoid infinite retry.