Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemDB does not reuse free nodes #1375

Closed
zyguan opened this issue Jul 2, 2024 · 2 comments · Fixed by #1483
Closed

MemDB does not reuse free nodes #1375

zyguan opened this issue Jul 2, 2024 · 2 comments · Fixed by #1483
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions.

Comments

@zyguan
Copy link
Contributor

zyguan commented Jul 2, 2024

MemDB cannot reuse free nodes, which may lead to mem leak in some cases. If a DML writes many keys and it has been retried multiple times due to pessimistic lock error, MemDB would re-alloc nodes for each try. Refer to the following demo code, the mem usage of allocator keeps growing.

2024-07-02_151659
@zyguan zyguan changed the title MemDB do not reuse free nodes MemDB does not reuse free nodes Jul 5, 2024
@seiya-annie
Copy link

/report customer

@you06 you06 mentioned this issue Sep 11, 2024
Merged
@ti-chi-bot ti-chi-bot bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Sep 11, 2024
@zyguan
Copy link
Contributor Author

zyguan commented Oct 12, 2024

Fixed in ART based membuffer

@zyguan zyguan closed this as completed Oct 12, 2024
@cfzjywxk cfzjywxk mentioned this issue Oct 29, 2024
Closed
@you06 you06 mentioned this issue Oct 31, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 14, 2024
@you06 @cfzjywxk
membuffer: fix memory leak in red-black tree (#1483)
86678db 
close #1375, ref pingcap/tidb#56837

Signed-off-by: you06 <[email protected]>

Co-authored-by: cfzjywxk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

membuffer: fix memory leak in red-black tree you06/client-go
2 participants
@zyguan @seiya-annie