Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong usage about Poco::URI to support ipv6 #101

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Jul 1, 2022

Ref pingcap/tiflash#5247

Host of ipv6 addr http://[::1]:2379 is ::1. To visit ipv6 host, it's necessary to encode the IPv6 IP number in square brackets according to RFC 3986. We need to use URI::getAuthority.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliqi gengliqi merged commit 034d1e7 into tikv:master Jul 1, 2022
@solotzg solotzg deleted the patch-1 branch July 1, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants