Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_if_not_exists 参数感觉可以删除掉，目前代码中并没有相关的判断，目录总是创建的。 #176

Open
gcxfd opened this issue Jul 5, 2022 · 3 comments
Open

create_if_not_exists 参数感觉可以删除掉，目前代码中并没有相关的判断，目录总是创建的。 #176

gcxfd opened this issue Jul 5, 2022 · 3 comments

Comments

@gcxfd
Copy link
Contributor

gcxfd commented Jul 5, 2022

image
@GanZiheng
Copy link
Contributor

是的，和 read_only 是重复的，可以考虑删掉 create_if_not_exists。

gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
remove create_if_not_exists; see tikv#176
60c19a2
gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
remove create_if_not_exists; see tikv#176
aef9322 
Signed-off-by: gcxfd <[email protected]>
gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
remove create_if_not_exists; see tikv#176
376ae5f 
Signed-off-by: gcxfd <[email protected]>
gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
remove create_if_not_exists; see tikv#176
31a546f 
Signed-off-by: gcxfd <[email protected]>
gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
Cargo.toml edition update to 2021
5c7b9f0 
cargo upgrade
fix gen_range
cargo fmt
cargo clippy
fix agate_bench/src/main.rs
remove create_if_not_exists tikv#176

Signed-off-by: gcxfd <[email protected]>
gcxfd added a commit to rmw-lib/agatedb that referenced this issue Jul 6, 2022
@gcxfd
Cargo.toml edition update to 2021
d43e9b0 
cargo upgrade
fix gen_range
cargo fmt
cargo clippy
fix agate_bench/src/main.rs
remove create_if_not_exists tikv#176

Signed-off-by: gcxfd <[email protected]>
@zhangjinpeng87
Copy link
Member

Please use english since this is a global community. Thanks.

@BusyJay
Copy link
Member

BusyJay commented Jul 11, 2022

create_if_not_exists doesn't need to be read only. Users can always use write mode and do assertion on existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BusyJay @zhangjinpeng87 @GanZiheng @gcxfd