Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates to allow easy inheritance of Ghaf #164

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

brianmcgillion
Copy link
Collaborator

Ghaf is a framework to allow the easy creation of
virtualized edge devices. As such it should be
used to derive projects that are configured to
the specific use cases.

These templates allow for that easy creation.

Ghaf is a framework to allow the easy creation of
virtualized edge devices. As such it should be
used to derive projects that are configured to
the specific use cases.

These templates allow for that easy creation.

Signed-off-by: Brian McGillion <[email protected]>
@vilvo
Copy link
Contributor

vilvo commented Jun 6, 2023

Could we develop this approach so that we'd avoid <PROJ NAME> renaming separately here https://github.com/tiiuae/ghaf/pull/164/files#diff-cb02caf321218f41518829b1217328404d838b7caf4832abdf5cb46e9b148881R25

nix flake supports templates with both new and init allow project folder (name) as parameter and further



--arg name expr

Pass the value expr as the argument name to Nix functions.

--argstr name string

Pass the string string as the argument name to Nix functions

which could probably be used for this renaming instead.

@vilvo
Copy link
Contributor

vilvo commented Jun 6, 2023

--arg name expr

Pass the value expr as the argument name to Nix functions.

--argstr name string

Pass the string string as the argument name to Nix functions

which could probably be used for this renaming instead.

I checked that my proposal seems not supported NixOS/nix#4017 (comment)

I also tested the PR templates with:
nix flake new --template github:brianmcgillion/ghaf/templates#target-x86_64-generic ~/generic_ghaf
and it works like it says in the documentation.

@brianmcgillion brianmcgillion merged commit 44a8660 into tiiuae:main Jun 6, 2023
@brianmcgillion brianmcgillion deleted the templates branch December 5, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants