Skip to content

Commit

Permalink
Eliminate multi-data point timeseries
Browse files Browse the repository at this point in the history
Resolves open-telemetry#54

After a discussion we came to conclusion that there is no good use case
for having multiple data points. All possible ways to combine data points
that we imagined are either very expensive or make no semantic sense.

This commit eliminates timeseries that can have multiple data points and replaces
them with single data points.

If in the future we discover a use case for multiple data points we have 2
possible paths to extend the proto:

- Add a corresponding points repeated field in the Int64DataPoint.
- Introduce a different message type that is capable of storing multiple data
  points and assign it a different type in the MetricDescriptor.Type enum.

There are probably other ways as well.
  • Loading branch information
Tigran Najaryan committed Nov 27, 2019
1 parent d303063 commit 0512e7a
Show file tree
Hide file tree
Showing 4 changed files with 435 additions and 474 deletions.
5 changes: 2 additions & 3 deletions gen/go/agent/traces/v1/trace_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0512e7a

Please sign in to comment.