forked from open-telemetry/opamp-spec
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolves open-telemetry#101 Status compression was quite complicated and confusing. It used 4 different hashes and lots of code to enable compression and detection of lost messages (during server restarts). We simplified this significantly by doing this instead: - Eliminate all "hash" fields. - Allow omitting the sub-messages of AgentToServer message. When omitted it is implied that previously reported value of the sub-message is current (unchanged). - To detect lost messages have one auto-incremented sequence_num field AgentToServer message. Server can easily detect losses by just keeping the last sequence_num (as opposed to keeping 4 different hashes). Here is a PR that demonstrates how it works: open-telemetry/opamp-go#93 It is more than 100 lines of code removed.
- Loading branch information
1 parent
060673c
commit 3b40727
Showing
1 changed file
with
49 additions
and
96 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters