Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Collection Serlization error when using parental #123

Merged

Conversation

Smoggert
Copy link
Contributor

I attempted fixing a long time ago but taytay decided to change the name of the function last minute when merging the PR.
As a result this bug is still alive and kicking due to implementing a useless function.

This PR renames said function to the one taytay chose, and as a result it actually works.

To test:

/**
         * Implements: Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
         */
        SomeJob::dispatch(
        /**
         * Implements: HasChildren
         */
            SomeParentModelWithChildren::query()->get()
        );
        
        // queued job fails critically as it cannot deserialize the collection

After the change the job should correctly serliaze the models and be able to run.

Smoggert and others added 3 commits July 17, 2023 12:39
It seems the request change to laravel got updated after I made the PR so the actual function name is different.

This fixes this.
@driftingly driftingly merged commit 2f41ac4 into tighten:main Jan 12, 2024
6 checks passed
@driftingly
Copy link
Member

Thanks @Smoggert 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants