Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken button styles by disabling preflight #58

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix broken button styles by disabling preflight #58

merged 1 commit into from
Oct 11, 2022

Conversation

tominon
Copy link
Contributor

@tominon tominon commented Oct 10, 2022

This fixes transparent buttons issue described in laravel/nova-issues#4838 which is also present in this package.

@faxblaster
Copy link
Contributor

Hey @tominon! I'm not able to recreate this, so would you mind dropping a screenshot along with your nova-stripe version?

From reading the linked issue, it looks like that one is related to the davidpiesse/nova-toggle package, which I don't think we're using here. I could be missing something though.

@tominon
Copy link
Contributor Author

tominon commented Oct 11, 2022

Hey @faxblaster, I'm not using davidpiesse/nova-toggle package in my project, but facing exact the same issue with nova-stripe v2.0.3 and latest Nova version v4.15.2:

Steps to reproduce:

  1. Register the NovaStripe tool in app/Providers/NovaServiceProvider@tools
  2. Add action to custom resource and check the modal dialog:
    public function actions(NovaRequest $request)
    {
        return [
            new Actions\ExtendTeamTrial(),
        ];
    }

127 0 0 1_8000_nova_resources_teams_2

@faxblaster faxblaster added the safe to test This PR has been reviewed and is safe for Actions workflow run label Oct 11, 2022
Copy link
Contributor

@faxblaster faxblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional context, and the contribution! 👏 LGTM

@faxblaster faxblaster merged commit 026b120 into tighten:main Oct 11, 2022
@faxblaster faxblaster linked an issue Oct 11, 2022 that may be closed by this pull request
@tominon tominon deleted the disable-preflight branch October 11, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This PR has been reviewed and is safe for Actions workflow run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Button styles - Preflight
2 participants