Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PascalCase and remove kebab-case from components #40

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

rissajackson
Copy link
Contributor

No description provided.

@rissajackson rissajackson self-assigned this Aug 20, 2021
Copy link
Contributor

@faxblaster faxblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Leaving some quick comments that are nothing you did, but hopefully things you won't mind fixing when you have time? 😅

One thing we could fix here is the component registration. Currently, we're registering components like so:

export default {
    components: {
        "ChargesPaginationLinks": ChargesPaginationLinks,
    },
}

But, since we're using laravel-mix, which uses webpack/module loading, we can do it more simply.

export default {
    components: { ChargesPaginationLinks },
}

Comment on lines 24 to 31
export default {
components: {
'balance-card': BalanceCard,
'charges-table': ChargesTable,
'column-select': ColumnSelect,
'BalanceCard': BalanceCard,
'ChargesTable': ChargesTable,
'ColumnSelect': ColumnSelect,
},
data() {
return {
Copy link
Contributor

@faxblaster faxblaster Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, since 1) you didn't do it and 2) it'll be cleaned up with the Duster PR (#37), but the baseline indentation inside the <script> tag should be flush left.

<script>
export default {
    components: {
        'BalanceCard': BalanceCard,
        'ChargesTable': ChargesTable,
        'ColumnSelect': ColumnSelect,
    },
 }
 </script>

@rissajackson
Copy link
Contributor Author

Okay I made the changes. I also saw that sometimes the components had a trailing comma. I went ahead and went with trailing for all of them. If it would be better to not have it, I can easily take it out. Thanks for reviewing!

@faxblaster
Copy link
Contributor

@rissajackson - Yeah, let's remove the commas. They won't cause any problems, but typically we reserve trailing commas for a multi-line statement.

@rissajackson rissajackson merged commit 41c1a1e into main Aug 26, 2021
@rissajackson rissajackson deleted the rej/remove-kebab-case branch August 26, 2021 15:43
@faxblaster faxblaster mentioned this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants