Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy pointcloud topics and point types #198

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 19, 2024

PR Type

  • Improvement

Description

The PointXYZIR and PointXYZIRADT types are not used by Autoware anymore and are obsolete.
Remove their

  • publishers,
  • conversion functions,
  • type definitions and
  • documentation.

Review Procedure

Confirm Nebula works with Autoware even when these topics are removed. This does not need a build/launch: confirming that the topics are not used is enough.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Sep 19, 2024
@knzo25
Copy link
Collaborator

knzo25 commented Sep 24, 2024

@mojomex (cc: @drwnz )

Outside autoware, having the classic XYZI (I as a float) is quite standard. Would you prefer explicitly dropping compatibility with all non-autoware packages?

@drwnz
Copy link
Collaborator

drwnz commented Sep 24, 2024

@mojomex (cc: @drwnz )

Outside autoware, having the classic XYZI (I as a float) is quite standard. Would you prefer explicitly dropping compatibility with all non-autoware packages?

Good point Kenzo. Let's include it.

@mojomex mojomex marked this pull request as draft October 1, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants