Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Nebula Clang-compatible #160

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jun 4, 2024

PR Type

  • Improvement
  • Bug Fix

Related Links

Description

This PR moves the EIGEN_ALIGN16 from behind point structs to after the struct keyword, remaining compatible with GCC while enabling compilation with Clang (and enabling usage of all the great Clang tools 🎉)

⚠️ Note: Nebula still does not compile on the newest Clang version (18) due to a tricky error in transport_drivers. The newest version I have tested with is Clang 15.

Review Procedure

The code should still compile on GCC, but now compiles on Clang as well.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz June 4, 2024 13:57
@mojomex mojomex self-assigned this Jun 4, 2024
@mojomex mojomex requested a review from veqcc June 4, 2024 13:57
Copy link

@veqcc veqcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mojomex mojomex merged commit 3398471 into tier4:develop Jun 5, 2024
7 checks passed
@mojomex mojomex deleted the clang-compatibility branch June 10, 2024 07:39
@mojomex mojomex mentioned this pull request Jun 12, 2024
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants