[WIP] switch cellarea and reproject to use Proj #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a new `reproject` method that uses Proj to transform an array of values in place using `proj_trans_generic`, only allocating a Float64 output array. It also performs the reproject check before actually transforming the array. This decreases runtime on my machine from 4.168 ms (ArchGDAL) to 665.187 μs (Proj), and allocations from 35167 allocs: 1.254 MiB (ArchGDAL) to 108 allocs: 42.859 KiB (Proj).
This is a weakness of this method compared to the old ArchGDAL method. Does this need a fix in Proj?
|
@rafaqz @tiemvanderdeure this passes CI on my local machine, hopefully it passes up here too, but if not it probably needs the Proj PR I linked (at least) + maybe one more to auto-add |
|
I have no clue why CI is failing, something in |
|
it's super weird but for sure not related to this PR. Must be some package released a new version that broke this? I'll just merge this and we can figure the tests out later. |
tiemvanderdeure
merged commit c890a83
into
tiemvanderdeure:better_cellsize
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Currently, reproject has an 8x speedup or so, and a lot less allocations too.
Needs some changes from JuliaGeo/Proj.jl#111