Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework file opening behavior #205

Closed
wants to merge 3 commits into from
Closed

Conversation

crew102
Copy link

@crew102 crew102 commented Sep 13, 2018

This PR addresses the file.edit problem discussed in #204 and also changes the undo functions so that they always open up a file containing the clean r code (see #67 (comment) for discussion)

@crew102 crew102 changed the title use different versions of file.edit depending on OS and IDE rework file opening behavior Sep 17, 2018
@crew102
Copy link
Author

crew102 commented Sep 28, 2018

Hi @jennybc , just wanted to ping you on this. Do you want me to rebase on top of master before you review?

@jennybc
Copy link
Member

jennybc commented Sep 29, 2018

Sure. I will be absorbed in preparing and delivering a workshop for the next week of work. usethis is sort of "resting" at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants