Add format_ISO8601 with methods #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vspinu
approved these changes
Jul 26, 2018
R/format_ISO8601.r
Outdated
| #' more precise than \code{max_precision}, a warning is given and | ||
| #' \code{max_precision} is returned. | ||
| format_ISO8601_precision_check <- function(precision, max_precision, usetz=FALSE) { | ||
| precision_map <- list(y="%Y", |
There was a problem hiding this comment.
This should be stored outside of the function to avoid construction on every call.
R/format_ISO8601.r
Outdated
| if (is.null(precision)) { | ||
| precision <- max_precision | ||
| } | ||
| if (!(precision %in% names(precision_map))) { |
There was a problem hiding this comment.
Micro optimization: if (is.null(ret <- precision_map[[precision]]) { ...}
R/format_ISO8601.r
Outdated
| stop("Invalid value for precision provided: ", precision) | ||
| } | ||
| if (nchar(precision) > nchar(max_precision)) { | ||
| warning("More precision requested (", precision, ") than allowed (", max_precision, ") for this format. Using maximum allowed precision.") |
There was a problem hiding this comment.
Could you please split this line ?
| #' "ymdhm" would show precision through minutes. When \code{NULL}, full | ||
| #' precision for the object is shown. | ||
| #' @param ... Additional arguments to methods. | ||
| #' @return A character vector of ISO8601-formatted text. |
There was a problem hiding this comment.
Could you please add @references with wiki page for ISO8601 format?
|
You will also have to add S4 aliases, otherwise CRAN check complains. |
|
I think that what I just pushed addresses all of the suggestions (while Travis checks are pending). |
|
Thanks 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #629