Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compute for Teradata #1126

Closed
wants to merge 1 commit into from
Closed

fix compute for Teradata #1126

wants to merge 1 commit into from

Conversation

But2ene
Copy link

@But2ene But2ene commented Feb 5, 2023

This PR was created to share some fix for Teradata used at work. It should fix #147

Indexes must be passed at table creation.

Happy to correct code style / design choices / etc...

indexes must be passed at table creation.
@But2ene But2ene changed the title fix compute for Teradata fix compute for Teradata Feb 5, 2023
@mgirlich mgirlich force-pushed the main branch 2 times, most recently from 0d1659e to 6683f25 Compare June 30, 2023 12:00
@mgirlich
Copy link
Collaborator

@hadley Any idea how you want to handle this? Returning "select 1" in sql_table_index.Teradata() doesn't feel right. It should probably error as it doesn't work anyway.

@hadley
Copy link
Member

hadley commented Oct 27, 2023

Actually I don't see why this is a problem since indexes and unique_indexes default to NULL, so sql_table_index will be never be called. I think we need more details here. (It also seems unrelated to #147).

@hadley
Copy link
Member

hadley commented Dec 21, 2023

@But2ene if this is still troubling you, I'd recommend starting by filing an issue with reprex so we can look into the underlying cause in more detail.

@hadley hadley closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute does not work with teradata
3 participants