address compute_grid_info() bug for partially regular grids
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
added a commit
to tidymodels/extratests
that referenced
this pull request
Nov 4, 2024
simonpcouch
commented
Nov 4, 2024
Comment on lines
+346
to
348
| if (isTRUE(model_iters_needed)) { | ||
| res$.iter_model <- res$.iter_model - 1 | ||
| } |
There was a problem hiding this comment.
Not super happy with this pattern—feels like I'm missing a much simpler off-by-one fix?
|
Unrequesting, as there's an additional snap change in extratests🫠 |
simonpcouch
added a commit
that referenced
this pull request
Nov 12, 2024
These tests will fail with current `main` but pass with #960. Max will file a PR today with a new draft of the helper, and that helper ought to pass these tests.
|
Closing in favor of an incoming PR from Max! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #959.