truncate variable descriptions that are wider than the console #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
commented
Sep 17, 2024
Comment on lines
+10
to
+12
| test_that("print method fits linewidth with many predictors (#543)", { | ||
| expect_snapshot(specify(mtcars, mpg ~ cyl + disp + hp + drat + wt + qsec)) | ||
| }) |
There was a problem hiding this comment.
Note that test_that() runs inside of local_reproducible_output(), so this test should always have a console width of 80.
|
Nice! Looks good to me. Thanks for the quick turnaround. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543. Takes the tibble-esque approach of just truncating the variable descriptions and then ending with ellipses rather than "wrapping" the whole description to the console width, though I'm game to do the latter if we feel that's a better approach.