Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address warnings when shading zero area #529

Merged
merged 8 commits into from
Mar 25, 2024
Merged

address warnings when shading zero area #529

merged 8 commits into from
Mar 25, 2024

Conversation

simonpcouch
Copy link
Collaborator

Closes #528. With this PR:

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(forcats)
library(infer)

set.seed(123)

gss <- gss |> 
   mutate(class = fct_drop(class))

h0 <- gss |> 
   specify(class ~ college) |> 
   hypothesise("independence") |> 
   generate(1000, "permute") |> 
   calculate("chisq")

hA <- gss |> 
   specify(class ~ college) |> 
   calculate("chisq")

# two warnings
visualise(h0) +
 shade_p_value(hA, "right")

Created on 2024-03-25 with reprex v2.1.0

the `get_p_value()` `obs_stat` lines tend to be slightly slimmer in the new versions of all of these.
slight changes in range for all, barely noticeable.
Merge branch 'main' into fix-528

# Conflicts:
#	NEWS.md
@simonpcouch simonpcouch merged commit 2c5e800 into main Mar 25, 2024
8 checks passed
@simonpcouch simonpcouch deleted the fix-528 branch March 25, 2024 16:42
Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings about aesthetic length and no non-missing argument to min in visualise + shade_p_value functions
1 participant