php: Simplify the end-user installation with a helper script #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides making the instructions simpler, this also improves the robustness of
the Docker image, because we can adjust filenames and directory structure as
necessary.
The Debian Dockerfile has been synchronized with the Alpine one, embedded the
SHA-256 hash of the regular downloads, instead of going through `apt`, as this
simplifies the placement in the top-level `/tideways/` directory without
unecessary duplication or complicated cleanup.
The updated instructions are now as follows:
Debian:
COPY --from=ghcr.io/tideways/php:latest /tideways/ /tideways/
RUN docker-php-ext-enable --ini-name tideways.ini $(php /tideways/get-ext-path.php)
Alpine:
COPY --from=ghcr.io/tideways/php:alpine /tideways/ /tideways/
RUN docker-php-ext-enable --ini-name tideways.ini $(php /tideways/get-ext-path.php)
The previous instructions are no longer valid, but they have not yet been
documented.
edorian
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides making the instructions simpler, this also improves the robustness of the Docker image, because we can adjust filenames and directory structure as necessary.
The Debian Dockerfile has been synchronized with the Alpine one, embedded the SHA-256 hash of the regular downloads, instead of going through
apt, as this simplifies the placement in the top-level/tideways/directory without unecessary duplication or complicated cleanup.The updated instructions are now as follows:
Debian:
Alpine:
The previous instructions are no longer valid, but they have not yet been documented.