Remove Jellyfish (UPLOAD-1, UPLOAD-1399) #1599
Conversation
…pload through platform
…w only upload through platform" This reverts commit 39085e0.
gniezen
changed the title
| @@ -130,9 +130,12 @@ export class App extends Component { | |||
| ? JSON.parse(localStore.getItem('selectedEnv')) | |||
| : null; | |||
|
|
|||
| this.props.async.fetchInfo(() => { | |||
| this.props.async.fetchInfo((err, info) => { | |||
There was a problem hiding this comment.
it appears we aren't doing anything with the err?
There was a problem hiding this comment.
If there is an error we already dispatch an error message in fetchInfo itself, so I'll just log it to the console.
lib/commonFunctions.js
Outdated
| } | ||
| }; | ||
|
|
||
| exports.strip = function(record) { |
There was a problem hiding this comment.
stripUnwantedFields or deleteUnwantedFields ... or just something a bit more descriptive?
lib/core/device.js
Outdated
| /* eslint-disable global-require, import/no-unresolved, import/extensions */ | ||
| device.deviceDrivers.Tandem = require('../drivers/tandem/tandemDriver'); | ||
| device.deviceDrivers.TandemJellyfish = require('../drivers/tandem/jellyfish/tandemDriver'); | ||
| } catch (e) { |
There was a problem hiding this comment.
error detail is of no use? also should it be err for the sake of consistency?
There was a problem hiding this comment.
Yeah, not really of any use, as it will just say the file can't be found if you don't have access to the private submodule. I'll rename it to err for consistency.
lib/core/device.js
Outdated
|
|
||
| const dm = device.createDriverManager(driverId, options); | ||
| if (dm == null) { | ||
| cb(new Error('Driver not available.')); |
There was a problem hiding this comment.
would the context of the driverId we are trying to create help here in the error?
There was a problem hiding this comment.
Sure, I can add it to the error message.
| @@ -177,3 +177,128 @@ exports.addDurationToDeviceTime = function (event, duration) { | |||
| }; | |||
|
|
|||
| exports.fixFloatingPoint = (n) => Math.floor(n * 100 + 0.5) / 100; | |||
|
|
|||
| Number.prototype.toFixedNumber = function(significant){ | |||
There was a problem hiding this comment.
I know it's not exported but is there a test?
| return +( Math.round(this*pow) / pow ); | ||
| }; | ||
|
|
||
| exports.updateDuration = function(event, lastEvent) { |
There was a problem hiding this comment.
is there a corresponding test?
Addresses UPLOAD-1. Supersedes #719 .