Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACK-3125] Add SMART identity provider #30

Open
wants to merge 5 commits into
base: tk-keycloak-25-no-homeidp
Choose a base branch
from

Conversation

toddkazakov
Copy link
Collaborator

No description provided.

try {
SimpleHttp.Response response = request.asResponse();
if (response.getStatus() != 200) {
String msg = "failed to invoke url [" + smartConfigurationUrl + "]";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the default since the throw new IdentityBrokerException("Failed to invoke url [" + smartConfigurationUrl + "]: " + msg); would produce something like throw new IdentityBrokerException("Failed to invoke url [" + smartConfigurationUrl + "]: " + "failed to invoke url [" + smartConfigurationUrl + "]") - seems like it's just repeating it at that point.

if (LOG.isTraceEnabled()) {
IParser parser = ctx.newJsonParser();
String serialized = parser.encodeResourceToString(practitioner);
LOG.tracef("Retrieved practitioner resource: " + serialized);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be using an actual string format, LOG.tracef("....%s", serialized) ?


Practitioner practitioner = getPractitioner(idToken.getSubject(), accessToken);
for (ContactPoint c : practitioner.getTelecom()) {
if (c.getSystem() == ContactPoint.ContactPointSystem.EMAIL && c.getValue() != null && !c.getValue().isEmpty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use c.getValue().isBlank() instead of c.getValue().isEmpty() - not sure if it can ever be whitespace though.

@toddkazakov
Copy link
Collaborator Author

@lostlevels ready for final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants