Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACK-2540] Print reports #43

Merged
merged 64 commits into from
Sep 19, 2023
Merged

[BACK-2540] Print reports #43

merged 64 commits into from
Sep 19, 2023

Conversation

jh-bate
Copy link
Contributor

@jh-bate jh-bate commented Jun 21, 2023 •
edited
Loading

allow pdf reports to be created from backend

docs tidepool-org/TidepoolApi#77

jh-bate and others added 30 commits June 21, 2023 14:59
@jh-bate
wip - initial creation of report handler
1992f6c
@jh-bate
move common code and create lib
588b606
@jh-bate
lint cleanup
b305591
@jh-bate
move log to utils
c4f88dc
@jh-bate
notes
2e8e811
@krystophv
extreme WIP for SSR PDF gen
d0f3405
@jh-bate
move to report utils
316f0ec
@jh-bate
update node version
4dc6d2b
@jh-bate
general utility functions
b0604d8
@jh-bate
remove console log statements
03101c6
@jh-bate
addition of get endpoint and userReportsHandler
cbfeaea
@jh-bate
update yarn lock
712f501
@jh-bate
cleanup
823132d
@jh-bate
cleanup
e74995f
@krystophv
small fixes
bf8c1aa
@jh-bate
updates to process all report types
bb0c73a
@jh-bate
include profile dob and fullname
7174a0a
@krystophv
minor logging and error handling cleanup
e253cea
@krystophv
ignore pre-built file for linting
24844b6
@jh-bate
common report code for get or post handler to call
a88f2bb
@jh-bate
basic tests
29bafc0 
updates for consistency to use `require` rather than import
@jh-bate
unique counter names, post body params
2c5dbea
@jh-bate
test for individual data types
1ff371e
@krystophv
Merge pull request #46 from tidepool-org/generation_post_tests
4c368a2 
add 'post' report, include basic tests
@krystophv
Merge pull request #47 from tidepool-org/pdf_generation_jhb
cb449f2 
PDF Generation
@krystophv
POST will use standard session header
36d398b
@krystophv
remove static pdfkit, update viz, tweak require/export
97fb771
@krystophv
add json body parser for POST
9ce8d0a
@krystophv
default bgLog 30 days, wrap fs output in debug env var
61fdb2f
@krystophv
test before build
d4cbbb3
jh-bate and others added 5 commits July 20, 2023 11:34
@jh-bate
use --frozen-lockfile
386c1ff
@krystophv @jh-bate
test out JS module conversion (#50)
904b3d0 
* test out JS module conversion

* tests update for cjs and rename file type for consistency

---------

Co-authored-by: Jamie <[email protected]>
@krystophv
convert from CJS to ESM
aaa2030
@krystophv
Merge pull request #51 from tidepool-org/cjs_to_esm
ee3ad46 
convert from CJS to ESM
@krystophv
Merge pull request #49 from tidepool-org/report_class
6e67644 
Report class
@jh-bate jh-bate marked this pull request as ready for review July 25, 2023 20:04
@jh-bate jh-bate mentioned this pull request Jul 25, 2023
Open
@krystophv
Copy link
Member

/deploy qa2

clintonium-119
clintonium-119 requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this. Just one small suggested change to one of the unit tests.

lib/report.js Show resolved Hide resolved
test/report_test.js Outdated Show resolved Hide resolved
clintonium-119
clintonium-119 previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job on this!

clintonium-119
clintonium-119 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@clintonium-119 clintonium-119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@krystophv krystophv merged commit c00c2e5 into master Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintonium-119 clintonium-119 clintonium-119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jh-bate @krystophv @clintonium-119