Qae 223 targetrange #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests when a user modifies the clinic profile, the supressednotification setting is preserved (true)
…iables replaced credentials and environment url with environment variables that are read in at runtime (hardcoded values replaced in suppressedNotificationsTrueCheck.js, suppressedNotificationsTrue.js)
…pdates -renamed custom commands files -refactored so that returned a result and moved assertion to calling test -added @ROLE=button to various page objects -replaced === in various comparisons
…iables added -js doc style comments added for each sub function inside suppressed notification functions -hard coded values for clinic id and clinician id moved to global variables in nightwatch.conf.js -
modifed file import in captureScreenshot.js so that it loads correctly
…nsFunctional add parallel tag to clinicianPageFunctional and suppressedNotificationsFunctional
first test for rpm stats file comparison test
Added functions for filters, rpm export button, and checks if sufficiency column meets criteria. Automated tests implemented checked as completed in test strategy spreadsheet: https://docs.google.com/spreadsheets/d/1gv5q_o5ghR_KMENYvsFmFxGVjKz020O9/edit?usp=sharing&ouid=117042773141856291352&rtpof=true&sd=true fix to start date and end date out of range click added logic to click previous month button if start date or end date was out of range in calendar view additional tests for filters last2days, last14days, last30days, today, and allranges split tests rpmStatsFunctionality file into multiple conditions
fixed all es lint errors excluding class-methods-use-this since it results in a nighwatch error
fileName param documentation added
-login test -go to workspace test -tag name
function checkFile -> checkFileExistence documentation added/updated
function checkFile -> checkFileExistence documentation added/updated
Co-authored-by: Vojtěch Červený <[email protected]>
brian-tidepool
requested review from
ginnyyadav and
vojtech-cerveny
and removed request for
ginnyyadav
ginnyyadav
approved these changes
Sep 3, 2024
| Name,Date of Birth,MRN,# Days With Qualifying Data between 05/01/2024 and 05/30/2024,Sufficient Data for CPT-99454 | ||
| "autodex1","01/01/2000",N/A,30,TRUE | ||
| "autodex2","02/02/2002","DEXCOM",30,TRUE | ||
| "autodex3","01/01/2000","DEXCOM2",30,TRUE |
There was a problem hiding this comment.
put test artifct files in circle ci (store test artificats comman)
| const utils = require('../../modules/utilsProfilePage'); | ||
|
|
||
| module.exports = { | ||
| '@tags': ['qae-223rangemgdl', 'clinician', 'parallel'], |
| fileName; | ||
| ({ | ||
| startDate, endDate, startDateFile, endDatefile, fileName, | ||
| } = await browser.createDatesLong(start, end)); |
There was a problem hiding this comment.
perhaps more description for what is dateslong vs dates short
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of qae-223 , adds tests for target range section in units mmol/l and mg/dl
review required only for commit b7e7c5b (previous commits already reviewed)