Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qae 223 targetrange #39

Open
wants to merge 88 commits into
base: main
Choose a base branch
from
Open

Qae 223 targetrange #39

wants to merge 88 commits into from

Conversation

brian-tidepool
Copy link
Contributor

@brian-tidepool brian-tidepool commented Aug 26, 2024

continuation of qae-223 , adds tests for target range section in units mmol/l and mg/dl

review required only for commit b7e7c5b (previous commits already reviewed)

brian-tidepool and others added 30 commits May 30, 2024 22:13
tests when a user modifies the clinic profile, the supressednotification setting is preserved (true)
…iables

replaced credentials and environment url  with environment variables that are read in at runtime

(hardcoded values replaced in suppressedNotificationsTrueCheck.js, suppressedNotificationsTrue.js)
…pdates

-renamed custom commands files
-refactored so that returned a result and moved assertion to calling test
-added @ROLE=button to various page objects
-replaced === in various comparisons
…iables added

-js doc style comments added for each sub function inside suppressed notification functions
-hard coded values for clinic id and clinician id moved to global variables in nightwatch.conf.js
-
modifed file import in captureScreenshot.js so that it loads correctly
…nsFunctional

add parallel tag to clinicianPageFunctional and suppressedNotificationsFunctional
first test for rpm stats file comparison test
Added functions for filters, rpm export button, and checks if sufficiency column meets criteria.
Automated tests implemented checked as completed in test strategy spreadsheet: https://docs.google.com/spreadsheets/d/1gv5q_o5ghR_KMENYvsFmFxGVjKz020O9/edit?usp=sharing&ouid=117042773141856291352&rtpof=true&sd=true

fix to start date and end date out of range click

added logic to click previous month button if start date or end date was out of range in calendar view

additional tests for filters last2days, last14days,  last30days, today, and allranges

split tests rpmStatsFunctionality file into multiple conditions
fixed all es lint errors excluding class-methods-use-this since it results in a nighwatch error
fileName param documentation added
@brian-tidepool brian-tidepool requested review from ginnyyadav and vojtech-cerveny and removed request for ginnyyadav August 26, 2024 07:25
Copy link
Member

@ginnyyadav ginnyyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put test artificats in a different PR. change tags on tests

Name,Date of Birth,MRN,# Days With Qualifying Data between 05/01/2024 and 05/30/2024,Sufficient Data for CPT-99454
"autodex1","01/01/2000",N/A,30,TRUE
"autodex2","02/02/2002","DEXCOM",30,TRUE
"autodex3","01/01/2000","DEXCOM2",30,TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not upload this one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put test artifct files in circle ci (store test artificats comman)

const utils = require('../../modules/utilsProfilePage');

module.exports = {
'@tags': ['qae-223rangemgdl', 'clinician', 'parallel'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need jira tags here

fileName;
({
startDate, endDate, startDateFile, endDatefile, fileName,
} = await browser.createDatesLong(start, end));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps more description for what is dateslong vs dates short

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants