Build fixes for Tidal 1.9 #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the nix build issue encountered at tidalcycles#1022, mentioned in tidalcycles#1022 (comment). Namely, as Tidal 2.0 requires `hosc` `0.20` but nixpkgs currently only provides `0.19.1`, we temporarily include `hosc` `0.20` directly from its source. This commit also updates the nixpkgs pin to the latest version while we're at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 1.9 branch has some of the same build issues that were resolved for 2.0 by #1020 and #1022. Some of the 2.0 issues aren't applicable here (e.g.
tidal-parsenot building because it hadn't been updated for 2.0), so I'm going to move patches over individually until the build stops failing.