Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FormFragment. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Robin-AF
Copy link

For my integration I needed the base to be a Fragment instead of an Activity.
Now users can use the Fragment instead of Activity in case they want to :)

@tianzhuqiao
Copy link
Owner

Thanks @Robin-AF, do you mind to provide some example to use the code?

@Robin-AF
Copy link
Author

Hi @tianzhuqiao yes, currently you need to have an activity and inherit from FormActivity like so:

class MainActivity : FormActivity() {

But because it's common in Android to use fragments it might be useful to be able to inherit from a fragment like so:

class MainActivity : FormFragment() {

This allows users to still create a form when they are in a Fragment instead of a Activity.

@tianzhuqiao
Copy link
Owner

Great, make sense. And in your commit, do you mind to add some demo code in the demo App? I think it will be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants