Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to filter option #3

Closed
wants to merge 2 commits into from
Closed

Add type to filter option #3

wants to merge 2 commits into from

Conversation

charlieegan3
Copy link
Contributor

Hello tiansh! 👋

Thanks for creating this addon, I find it to be very helpful.

This PR adds a new feature which allows users to type to select containers on the new tab page. It looks a little like this in action:
ezgif com-video-to-gif

If the typed prefix matches a single container, that container is immediately used to open the new tab. In the clip, none of my containers start with x, however only one starts with p so as soon as I press that key the addon opens the URL in that container.

I hope 匹配前缀的容器 means what I think it does!

This feature allows users to type to select containers on the new tab
page.

Signed-off-by: Charlie Egan <[email protected]>
Not sure how I missed this last night...
@tiansh tiansh closed this Sep 16, 2020
@tiansh
Copy link
Owner

tiansh commented Sep 16, 2020

I had merged the pr. I'm not sure why github show it closed instead of merged... You can still checkout the commit log anyway...

@tiansh
Copy link
Owner

tiansh commented Sep 16, 2020

I had made some edition on it:

  • It will hint typed text by highlight buttons using underscore.
  • It accept Esc key to cancel whole input.
  • Using Tab after input prefix will only navigate between selected buttons.
  • It focus first matched button with matched typing.
  • It reset typed text to empty string if no matching found.

Hope you like these changes.

@charlieegan3
Copy link
Contributor Author

Amazing! Yeah this all sounds good. I pulled the new version and it works well for me. Thanks for merging it so quickly. Do you know when it'll update on for installation on mozilla?

@charlieegan3 charlieegan3 deleted the type-to-filter branch September 16, 2020 14:34
@charlieegan3
Copy link
Contributor Author

edit, looks like it's there now!
Screenshot from 2020-09-16 15-44-46

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants