Decouple package dependencies of StandaloneMmPkg #10671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:breaking-change
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jiaxinwu,
leiflindholm,
niruiyu,
samimujawar and
td36
os-d
reviewed
Jan 24, 2025
os-d
approved these changes
Jan 24, 2025
This library is specific for AArch64 platforms and the only consumer is the StandaloneMmCoreEntryPointLib for AArch64 library in ArmPkg, make it more reasonable to dwell in the ArmPkg. This change moves the library from StandaloneMmPkg to ArmPkg and updated the package dependency for cleaner package relationship. Cc: Leif Lindholm <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Sami Mujawar <[email protected]> Cc: Ray Ni <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Dun Tan <[email protected]> Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Kun Qin <[email protected]>
This change adds a null instance of StandaloneMmCoreEntryPoint to satisfy CI and pipeline builds for various architectures without coupled package dependencies. Cc: Ard Biesheuvel <[email protected]> Cc: Sami Mujawar <[email protected]> Cc: Ray Ni <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Dun Tan <[email protected]> Signed-off-by: Kun Qin <[email protected]> Co-authored-by: Bret Barkelew <[email protected]>
leiflindholm
requested changes
Jan 25, 2025
There was a problem hiding this comment.
We're seeing a highly unfortunate flurry of cleaning up StandaloneMmPkg by chucking bits over to ArmPkg. As per #10289, ArmPkg should be shrinking, not growing.
What is the problem that is being solved by this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves the
StandaloneMmPeCoffExtraActionLibfrom StandaloneMmPkg to ArmPkg because this library is specific to ARM platforms and the only consumer is in the ArmPkg.In addition, a null instance of the library was created to satisfy CI and pipeline builds for various architectures without coupled package dependencies
How This Was Tested
This change does not impact any functionality.
Integration Instructions
Platforms need to update their
StandaloneMmPeCoffExtraActionLibinstance to point toArmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf