RedfishClientPkg/Feature: Default detection #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition When BIOS loads default settings and remove all variables, Redfish feature driver should ignore stale settings on BMC and force update default settings to BMC. Signed-off-by: Nickle Wang <[email protected]>
When BIOS loads default settings and remove all variables, Redfish feature driver should ignore stale settings on BMC and force update default settings to BMC. Code optimization: - Only consume attributes when number of attributes is not zero. - Only convert Bios structure to JSON data when attribute value is changed. - Initial variable before using it. - Return EFI_SUCCESS when there is nothing to update and prevent false alarm. - In check() function, return EFI_UNSUPPORTED when there is no config language found for this Redfish resource. And return EFI_NOT_FOUND when there is config language found but they are missing at BMC. This is to match the check() function description and feature driver can understand how to handle these two case separately. Signed-off-by: Nickle Wang <[email protected]>
igorkulchytskyy
approved these changes
Aug 20, 2024
changab
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How This Was Tested
Build pass on RedfishClinetPkg