Use POST for provisioning Bios attributes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghbaccount
force-pushed
the
Use_POST_for_provisioning
branch
2 times, most recently
from
9b3d7fc to
3f9d119
Compare
Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Igor Kulchytskyy <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]> Reviewed-by: Nickle Wang <[email protected]> Reviewed-by: Abner Chang <[email protected]>
Cc: Igor Kulchytskyy <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]> Reviewed-by: Nickle Wang <[email protected]> Reviewed-by: Abner Chang <[email protected]>
It is possible that at the time of accessing to AsciiLocation pointer
the memory is not allocated.
Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for
this case:
RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used uninitialized in this function [-Werror=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Igor Kulchytskyy <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]>
Reviewed-by: Abner Chang <[email protected]>
ghbaccount
force-pushed
the
Use_POST_for_provisioning
branch
from
3f9d119 to
c468a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set contains small fixes and the one major change related to Bios resources provisioning.