EdkRepo: Updating messaging framework to be more consistent #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Colorama issue and discussion found at tartley/colorama#140 |
ashedesimone
approved these changes
Mar 20, 2022
Refactoring to establish consistent standardized messaging framework in all commands by making the --color parameter accessible to all commands. Signed-off-by: Kevin Sun <[email protected]> Reviewed-by: Ashley E Desimone <[email protected]>
Refactoring to avoid known colorama behavior that would cause an exponentially increasing amount of recursive calls resulting in an exception storm. Signed-off-by: Kevin Sun <[email protected]> Reviewed-by: Ashley E Desimone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to allow messaging framework to be accessible in all commands through inheritance, rather than in a select few commands. Also avoids known colorama behavior that would cause an exponential amount of recursive exceptions.
Signed-off-by: Kevin Sun [email protected]