EdkRepo: Update the Sync Command to Support Local Directory Renames and URL Changes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset print formatting in SYNC_REMOVE_LIST_END_FORMATTING by changing it to Style.RESET_ALL Signed-off-by: Ashley E Desimone <[email protected]>
edkrepo/common/humble.py
Outdated
| @@ -57,7 +57,12 @@ | |||
| FETCHING = 'Fetching latest code for {0} from {1} branch ...' | |||
| NO_SYNC_DETACHED_HEAD = 'No need to sync repo {0} since it is in detached HEAD state' | |||
| SYNC_MANIFEST_UPDATE = 'To update to the latest manifest please run edkrepo sync --update-local-manifest. {}'.format(Fore.RESET) | |||
| SYNC_REMOVE_LIST_END_FORMATTING = '{}'.format(Fore.RESET) | |||
| SYNC_REMOVE_LIST_END_FORMATTING = '{}'.format(Style.RESET_ALL) | |||
| SYNC_MOVE_FAILED = '''{}{}WARNING:{}{} Moving {{}} to {{}} failed. | |||
There was a problem hiding this comment.
We should make this a little more readable. Adding labels like {{old_dir}} and {{new_dir}} should make this much more readable.
edkrepo/commands/sync_command.py
Outdated
| try: | ||
| shutil.move(old_dir, new_dir) | ||
| except: | ||
| print(SYNC_MOVE_FAILED.format(source.root, new_dir, new_dir, new_dir, source.root)) |
There was a problem hiding this comment.
With the comment below, this would need to change to:
print(SYNC_MOVE_FAILED.format(old_dir=source.root, new_dir=new_dir))
…d/or URL changes Updated comments to better describe the process of updating the local manifest file. Removed the exception that was raised when a URL change was detected. Updated the calculation of sources_to_move, sources_to_remove and sources_to_clone so that the inital repository is moved to an archival location and the updated respository is cloned. Signed-off-by: Ashley E Desimone <[email protected]>
nate-desimone
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.