EdkRepo: Specify the Python version in installed Python launcher #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +86,7 @@ public static string EdkrepoPython3LauncherScript | |||
| { | |||
| get | |||
| { | |||
| return "python3"; | |||
| return "python -3.8"; | |||
There was a problem hiding this comment.
This is not the command to run the Python interpreter. It is the file name for the shell script that launches the Python interpreter. This file name must continue to be "python3". Otherwise, "#!/usr/bin/env python3" will no longer work.
ashedesimone
force-pushed
the
py_launcher
branch
from
c5549ca to
d156390
Compare
nate-desimone
approved these changes
Nov 16, 2021
The Python launchers installed by EdkRepo should explicitly point to the supported version where possible allowing and git hooks to 'import edkrepo' if needed. Signed-off-by: Ashley E Desimone <[email protected]> Reviewed-by: Nate DeSimone <[email protected]>
ashedesimone
force-pushed
the
py_launcher
branch
from
d156390 to
a8e5661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python launchers installed by EdkRepo should explicitly point
to the supported version where possible allowing and git hooks to
'import edkrepo' if needed.
Signed-off-by: Ashley E Desimone [email protected]