EdkRepo: generate_pin_etree should also set CurrentClonedCombo #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashedesimone
requested changes
Apr 17, 2024
kevinsun49
force-pushed
the
generate-pin-combo
branch
from
9679f7e to
1e7c81b
Compare
ashedesimone
approved these changes
Apr 17, 2024
Currently takes the CurrentClonedCombo from the manifest file the pin is based off of. But it should be also setting it to the combo passed into the method, as that's the only <Combination> that will be present in the resulting pin file. Reviewed-by: Ashley E Desimone <[email protected]> Signed-off-by: Kevin Sun <[email protected]>
kevinsun49
force-pushed
the
generate-pin-combo
branch
from
1e7c81b to
23da6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently takes the CurrentClonedCombo from the manifest file the pin is based off of. But it should be also setting it to the combo passed into the method, as that's the only that will be present in the resulting pin file.