Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edkrepo checkout with SparseData combination can have wrong sparse fi… #132

Merged
merged 1 commit into from
Feb 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions edkrepo/common/common_repo_functions.py
Original file line number Diff line number Diff line change
@@ -586,8 +586,9 @@ def checkout(combination, global_manifest_path, verbose=False, override=False, l
sparse_diff = True
if sparse_diff:
break
if set([combo, manifest.general_config.current_combo]).issubset(set([data.combination for data in manifest.sparse_data])):
sparse_diff = True
if set([combo, manifest.general_config.current_combo]).isdisjoint(set([data.combination for data in manifest.sparse_data])) == False :
if combo != manifest.general_config.current_combo:
sparse_diff = True

# Recompute the sparse checkout if the dynamic sparse list is being used or
# there is a difference in the sparse settings / static sparse definition