edkrepo checkout with SparseData combination can have wrong sparse files checked out. #131
Comments
ndhaller
added a commit
to ndhaller/edk2-edkrepo
that referenced
this issue
Feb 15, 2023
…les checked out. tianocore#131 If either the current-combo or the combo-to-checkout use a combination-specific SparseData, re-initialize sparse data during checkout combo. Do not re-initialize sparse data if the current-combo and combo-to-checkout are the same combo. Signed-off-by: Nathaniel Haller <[email protected]>
|
Good catch @ndhaller! And thank you so much for fixing the bug! |
ashedesimone
pushed a commit
to ndhaller/edk2-edkrepo
that referenced
this issue
Feb 27, 2023
…les checked out. tianocore#131 If either the current-combo or the combo-to-checkout use a combination-specific SparseData, re-initialize sparse data during checkout combo. Do not re-initialize sparse data if the current-combo and combo-to-checkout are the same combo. Signed-off-by: Nathaniel Haller <[email protected]> Reviewed-by: Ashley E Desimone <[email protected]> Reviewed-by: Nate Desimone <[email protected]>
ashedesimone
pushed a commit
that referenced
this issue
Feb 27, 2023
…les checked out. #131 If either the current-combo or the combo-to-checkout use a combination-specific SparseData, re-initialize sparse data during checkout combo. Do not re-initialize sparse data if the current-combo and combo-to-checkout are the same combo. Signed-off-by: Nathaniel Haller <[email protected]> Reviewed-by: Ashley E Desimone <[email protected]> Reviewed-by: Nate Desimone <[email protected]>
|
Fixed closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you have two combo ("combo_A" and "combo_B"), both with sparseCheckout="true" on a remote repo ("repo"), but there is a section defined for "combo_A", and a global section used by all combo, the following two cases can happen:
While on "combo_A", running "edkrepo checkout combo_B" will not run the "Resetting sparse checkout state..." step and "Performing sparse checkout..." step.
While on "combo_B", running "edkrepo checkout combo_A" will not run the "Resetting sparse checkout state..." step and "Performing sparse checkout..." step.
-workaround: calling "edkrepo sync" after the 'checkout' command will reset to correct sparse checkout settings.
While on "combo_A", running "edkrepo checkout combo_A" will always cause the "Resetting sparse checkout state..." step and "Performing sparse checkout..." step to be run.
-workaround: none. this just makes the edkrepo checkout command take longer.
test environment: edkrepo 3.1.0, Python 3.8.10, git 2.39.1.windows.1, Windows 11.
The text was updated successfully, but these errors were encountered: