Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update types : EnumDepositStatus #496

Merged
merged 2 commits into from
Jan 1, 2025
Merged

update types : EnumDepositStatus #496

merged 2 commits into from
Jan 1, 2025

Conversation

mth-bou
Copy link
Contributor

@mth-bou mth-bou commented Dec 31, 2024

I added some new entries to EnumDepositStatus in /types/spot.d.ts as the doc says at this link

The following entries were missing :

  • WrongDeposit = 7
  • WaitingUserConfirm = 8
  • Rejected = 2

image

tiagosiebler
tiagosiebler requested changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@tiagosiebler tiagosiebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also increase the version number in the package.json? It'll make the release to npm a lot easier.

@mth-bou
Copy link
Contributor Author

mth-bou commented Dec 31, 2024

Done! Thank you for your work 😃

tiagosiebler
tiagosiebler approved these changes Jan 1, 2025
View reviewed changes
Copy link
Owner

@tiagosiebler tiagosiebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR. Should be available on npm shortly.

@tiagosiebler tiagosiebler merged commit 6a20147 into tiagosiebler:master Jan 1, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagosiebler tiagosiebler tiagosiebler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mth-bou @tiagosiebler