Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer integration for vscode #66

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add devcontainer integration for vscode #66

merged 2 commits into from
Sep 18, 2023

Conversation

andreas-kurz
Copy link
Contributor

@andreas-kurz andreas-kurz commented Jan 17, 2023

This will auto setup the whole build environment based on zephyr's docker containers. Prerequisites are:

  • docker is accessable by the user without using sudo
  • vscode with remote container extension is installed

Create a directory for your workspace. Go into that directory and clone the bridle repo.
Open the repo folder in vscode and select from the commands "Dev Containers: Reopen in container" (you might be prompted in the bottom right corner for that).

This will then download the docker container, install packages etc. so that you can directly start with a west build

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 90 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 30 days. Note, that you can always re-open a closed pull request at any time.

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 90 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 30 days. Note, that you can always re-open a closed pull request at any time.

@rexut
Copy link
Member

rexut commented Sep 16, 2023

@andreas-kurz Please, could you add your signed-off in the commit message and fix our QA Compliance Check:

ERROR   : Test Identity failed: 
28e54b00f69ffc46617591d9125058e967937f0c: author email (Andreas Kurz <[email protected]>) needs to match one of the signed-off-by entries.

@andreas-kurz
Copy link
Contributor Author

@andreas-kurz Please, could you add your signed-off in the commit message and fix our QA Compliance Check:

ERROR   : Test Identity failed: 
28e54b00f69ffc46617591d9125058e967937f0c: author email (Andreas Kurz <[email protected]>) needs to match one of the signed-off-by entries.

Sorry, seems like I forgot to add the ul address to my GPG key. And somehow my git commit didn't add the "signed-off by" to the message. Should be fixed now

Copy link
Member

@rexut rexut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks.

rexut and others added 2 commits September 18, 2023 09:54
This will auto setup the whole build environment based on zephyr's docker
containers. Prerequisites are:
- docker is accessable by the user without using sudo
- vscode with remote container extension is installed

Signed-off-by: Andreas Kurz <[email protected]>
Signed-off-by: Stephan Linz <[email protected]>
@rexut rexut merged commit 55e6f3d into main Sep 18, 2023
3 checks passed
@rexut rexut deleted the devcontainer branch September 18, 2023 15:16
@rexut
Copy link
Member

rexut commented Sep 18, 2023

@andreas-kurz Please, could you add your signed-off in the commit message and fix our QA Compliance Check:

ERROR   : Test Identity failed: 
28e54b00f69ffc46617591d9125058e967937f0c: author email (Andreas Kurz <[email protected]>) needs to match one of the signed-off-by entries.

Sorry, seems like I forgot to add the ul address to my GPG key. And somehow my git commit didn't add the "signed-off by" to the message. Should be fixed now

No problem. The signed-off was more important than missed GPG keys. Now I was able to rebase and sign by me. All fine, thnx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants