Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge if the number of lgtm is greater than the required number #367

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

Rustin170506
Copy link
Contributor

@ti-chi-bot ti-chi-bot requested a review from Mini256 February 28, 2021 02:37
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2021
@github-actions
Copy link

github-actions bot commented Feb 28, 2021

🎊 PR Preview 282925b has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-367.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #367 (282925b) into master (9734e5d) will decrease coverage by 0.11%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   83.82%   83.70%   -0.12%     
==========================================
  Files          14       14              
  Lines        1453     1516      +63     
==========================================
+ Hits         1218     1269      +51     
- Misses        139      144       +5     
- Partials       96      103       +7     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nal/pkg/externalplugins/blunderbuss/blunderbuss.go 89.87% <80.85%> (-3.04%) ⬇️
internal/pkg/externalplugins/merge/merge.go 82.12% <100.00%> (ø)
internal/pkg/externalplugins/tars/tars.go 80.00% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d55aad...282925b. Read the comment docs.

@Rustin170506
Copy link
Contributor Author

/retest

@Rustin170506
Copy link
Contributor Author

/test all

@Rustin170506
Copy link
Contributor Author

/assign @Mini256

PTAL~ Thanks!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2021
@Mini256
Copy link
Member

Mini256 commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 282925b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@ti-chi-bot ti-chi-bot merged commit 040d42b into ti-community-infra:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants