fix a panic issue in parallel agg when exception is thrown (pingcap#5433

) (pingcap#5442) close pingcap#5356
ti-chi-bot · Jul 22, 2022 · 4079241 · 4079241
1 parent 648f06a
commit 4079241
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
@@ -160,9 +160,8 @@ void ParallelAggregatingBlockInputStream::Handler::onFinish()
 void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
 {
     parent.exceptions[thread_num] = exception;
-    /// can not cancel parent inputStream or the exception might be lost
     if (!parent.executed)
-        parent.processor.cancel(false);
+        parent.cancel(false);
 }