ttl: modify default value of tidb_ttl_delete_batch_size to 100 (pin…

…gcap#39878) close pingcap#39877
ti-chi-bot · Dec 20, 2022 · a57de99 · a57de99
1 parent 4c53df4
commit a57de99
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/metrics/grafana/tidb.json b/metrics/grafana/tidb.json
@@ -17528,6 +17528,10 @@
         {
           "alias": "dispatch",
           "color": "#8F3BB8"
+        },
+        {
+          "alias": "wait_token",
+          "color": "#8AB8FF"
         }
       ],
       "spaceLength": 10,
@@ -17654,6 +17658,10 @@
         {
           "alias": "dispatch",
           "color": "#8F3BB8"
+        },
+        {
+          "alias": "wait_token",
+          "color": "#8AB8FF"
         }
       ],
       "spaceLength": 10,

diff --git a/sessionctx/variable/tidb_vars.go b/sessionctx/variable/tidb_vars.go
@@ -1139,7 +1139,7 @@ const (
 	DefTiDBTTLScanBatchSize                          = 500
 	DefTiDBTTLScanBatchMaxSize                       = 10240
 	DefTiDBTTLScanBatchMinSize                       = 1
-	DefTiDBTTLDeleteBatchSize                        = 500
+	DefTiDBTTLDeleteBatchSize                        = 100
 	DefTiDBTTLDeleteBatchMaxSize                     = 10240
 	DefTiDBTTLDeleteBatchMinSize                     = 1
 	DefTiDBTTLDeleteRateLimit                        = 0

diff --git a/ttl/metrics/metrics.go b/ttl/metrics/metrics.go
@@ -31,6 +31,7 @@ var (
 	PhaseCheckTTL  = "check_ttl"
 	PhaseWaitRetry = "wait_retry"
 	PhaseDispatch  = "dispatch"
+	PhaseWaitToken = "wait_token"
 	PhaseOther     = "other"
 )
 
@@ -58,6 +59,7 @@ func initWorkerPhases(workerType string) map[string]prometheus.Counter {
 		PhaseWaitRetry: metrics.TTLPhaseTime.WithLabelValues(workerType, PhaseWaitRetry),
 		PhaseDispatch:  metrics.TTLPhaseTime.WithLabelValues(workerType, PhaseDispatch),
 		PhaseCheckTTL:  metrics.TTLPhaseTime.WithLabelValues(workerType, PhaseCheckTTL),
+		PhaseWaitToken: metrics.TTLPhaseTime.WithLabelValues(workerType, PhaseWaitToken),
 		PhaseOther:     metrics.TTLPhaseTime.WithLabelValues(workerType, PhaseOther),
 	}
 }

diff --git a/ttl/ttlworker/del.go b/ttl/ttlworker/del.go
@@ -86,6 +86,10 @@ type ttlDeleteTask struct {
 }
 
 func (t *ttlDeleteTask) doDelete(ctx context.Context, rawSe session.Session) (retryRows [][]types.Datum) {
+	tracer := metrics.PhaseTracerFromCtx(ctx)
+	defer tracer.EnterPhase(tracer.Phase())
+	tracer.EnterPhase(metrics.PhaseOther)
+
 	leftRows := t.rows
 	se := newTableSession(rawSe, t.tbl, t.expire)
 	for len(leftRows) > 0 {
@@ -109,10 +113,12 @@ func (t *ttlDeleteTask) doDelete(ctx context.Context, rawSe session.Session) (re
 			)
 		}
 
+		tracer.EnterPhase(metrics.PhaseWaitToken)
 		if err = globalDelRateLimiter.Wait(ctx); err != nil {
 			t.statistics.IncErrorRows(len(delBatch))
 			return
 		}
+		tracer.EnterPhase(metrics.PhaseOther)
 
 		sqlStart := time.Now()
 		_, needRetry, err := se.ExecuteSQLWithCheck(ctx, sql)