statistics: fix the memory leak of region statistics (tikv#8711) (tik…

…v#8747) close tikv#8710 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: Ryan Leung <[email protected]>
ti-chi-bot · Oct 28, 2024 · 6d7be9a · 6d7be9a
1 parent b54c794
commit 6d7be9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/server/statistics/region_collection.go b/server/statistics/region_collection.go
@@ -283,6 +283,7 @@ func (r *RegionStatistics) ClearDefunctRegion(regionID uint64) {
 		}
 	}
 	if oldIndex, ok := r.offlineIndex[regionID]; ok {
+		delete(r.offlineIndex, regionID)
 		r.deleteOfflineEntry(oldIndex, regionID)
 	}
 }

diff --git a/server/statistics/region_collection_test.go b/server/statistics/region_collection_test.go
@@ -129,6 +129,10 @@ func TestRegionStatistics(t *testing.T) {
 	stores[3] = store3
 	regionStats.Observe(region1, stores)
 	re.Empty(regionStats.stats[OfflinePeer])
+
+	regionStats.ClearDefunctRegion(1)
+	re.Equal(1, len(regionStats.index))
+	re.Equal(1, len(regionStats.offlineIndex))
 }
 
 func TestRegionStatisticsWithPlacementRule(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     	}
     	if oldIndex, ok := r.offlineIndex[regionID]; ok {
+    		delete(r.offlineIndex, regionID)
     		r.deleteOfflineEntry(oldIndex, regionID)
     	}
     }
@@ Expand Down @@