Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: bs-logger is missing from the dependencies #1191

Closed
ocombe opened this issue Nov 22, 2021 · 4 comments · Fixed by #1192
Closed

[Bug]: bs-logger is missing from the dependencies #1191

ocombe opened this issue Nov 22, 2021 · 4 comments · Fixed by #1192
Labels
🐛 Bug Confirmed Bug is confirmed

Comments

@ocombe
Copy link

ocombe commented Nov 22, 2021

Version

11.0.0

Steps to reproduce

N/A

Expected behavior

bs-logger should be a dependency of jest-preset-angular since it's used in ng-jest-transformer

Actual behavior

Cannot find module 'bs-logger'
Require stack:
- C:\www\bit-capsules\62121062bf6973ee4631fe14f96ac4f1a3a927b4\node_modules\.pnpm\[email protected]_a7ccfb11043122fcd72a8780d7f7f03f\node_modules\jest-preset-angular\build\ng-jest-transformer.js
- C:\www\bit-capsules\62121062bf6973ee4631fe14f96ac4f1a3a927b4\node_modules\.pnpm\[email protected]_a7ccfb11043122fcd72a8780d7f7f03f\node_modules\jest-preset-angular\build\index.js
- C:\www\bit-angular\node_modules\.pnpm\[email protected]\node_modules\jest-util\build\requireOrImportModule.js
- C:\www\bit-angular\node_modules\.pnpm\[email protected]\node_modules\jest-util\build\index.js
- C:\www\bit-angular\node_modules\.pnpm\registry.npmjs.org+@[email protected][email protected]\node_modules\@jest\core\build\FailedTestsInteractiveMode.js
- C:\www\bit-angular\node_modules\.pnpm\registry.npmjs.org+@[email protected][email protected]\node_modules\@jest\core\build\plugins\FailedTestsInteractive.js
- C:\www\bit-angular\node_modules\.pnpm\registry.npmjs.org+@[email protected][email protected]\node_modules\@jest\core\build\watch.js
- C:\www\bit-angular\node_modules\.pnpm\registry.npmjs.org+@[email protected][email protected]\node_modules\@jest\core\build\cli\index.js
- C:\www\bit-angular\node_modules\.pnpm\registry.npmjs.org+@[email protected][email protected]\node_modules\@jest\core\build\jest.js
- C:\www\bit-angular\node_modules\.pnpm\[email protected][email protected]\node_modules\jest\build\jest.js
- C:\www\bit\node_modules\@teambit\jest\dist\jest.tester.js
- C:\www\bit\node_modules\@teambit\jest\dist\jest.main.runtime.js
- C:\www\bit\node_modules\@teambit\bit\dist\load-bit.js
- C:\www\bit\node_modules\@teambit\bit\dist\app.js
- C:\www\bit\bin\bit.js

Additional context

No response

Environment

System:
    OS: Windows 10 10.0.22000
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
  Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.19.1 - ~\AppData\Roaming\npm\npm.CMD
@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 22, 2021

hmm, npm isn't happy with indirect dependency but yarn is ok with it somehow. It's a dependency installed via ts-jest. I will add it to this repo dependency list too. Thanks for the your report :)

@ocombe
Copy link
Author

ocombe commented Nov 22, 2021

I'm using pnpm so it's even more strict than npm I think 🙂

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 22, 2021

Should be fine with 11.0.1, pls try out :)

@ocombe
Copy link
Author

ocombe commented Nov 22, 2021

Yes I've already updated my project, it works fine, thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Confirmed Bug is confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants