Adds a valid xmlns attribute to svg tag

thutterer · Jun 30, 2022 · c239774 · c239774
1 parent 4249f74
commit c239774
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/initials/svg.rb b/lib/initials/svg.rb
@@ -21,7 +21,7 @@ def name
 
     def to_s
       svg = [
-        "<svg width='#{size}' height='#{size}'>",
+        "<svg xmlns='http://www.w3.org/2000/svg' width='#{size}' height='#{size}'>",
           shape == :rect ?
             "<rect width='#{size}' height='#{size}' rx='#{size / 32}' ry='#{size / 32}' fill='#{fill}' />"
           :

diff --git a/spec/svg_spec.rb b/spec/svg_spec.rb
@@ -83,6 +83,12 @@
       end
     end
 
+    describe "svg tag" do
+      it "has valid xmlns attribute" do
+        expect(subject.to_s).to match(/^<svg xmlns='http:\/\/www.w3.org\/2000\/svg'.+<\/svg>/)
+      end
+    end
+
     describe "size" do
       let(:options) { {size: 512} }