Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of "Title wraps within word in Improve the Experience screen" #8322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shamim-emon
Copy link

@shamim-emon shamim-emon commented Oct 13, 2024

  • In Improve the Experience screen, moved the title below the icon

Fixes #8257

@shamim-emon shamim-emon changed the title Fix of "Title wraps within word in "Improve the Experience" screen" Fix of "Title wraps within word in Improve the Experience screen" Oct 13, 2024
@shamim-emon
Copy link
Author

@cketti @wmontwe please let me know if I've missed anything. Thanks!

@cketti
Copy link
Member

cketti commented Oct 15, 2024

Thanks for your pull request 👍

We have talked about this internally and decided on a path forward. Please see #8257 (comment)

I've created PR #8341 to switch to showing the brand name. Once that is merged it would be awesome if you could look into resizing the text so it fits the available width.

Side note: Please don't merge main into your pull request branch. If you want/need to update the pull request branch, rebase it on top of the updated main branch instead.

@shamim-emon
Copy link
Author

Thanks for your pull request 👍

We have talked about this internally and decided on a path forward. Please see #8257 (comment)

I've created PR #8341 to switch to showing the brand name. Once that is merged it would be awesome if you could look into resizing the text so it fits the available width.

Side note: Please don't merge main into your pull request branch. If you want/need to update the pull request branch, rebase it on top of the updated main branch instead.

@cketti I have made corresponding text auto resizable so it always fits the available width. Please let me know if that's alright and/or if anything else needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title wraps within word in "Improve the Experience" screen
2 participants