-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title wraps within word in "Improve the Experience" screen #8257
Comments
Hi, I'm new to contributing and currently learning Android development. |
@sens-sens please work on it, pull requests welcome! The TB Android dev room on Matrix is: https://matrix.to/#/#tb-android-dev:mozilla.org |
The code for the top app bar has inconsistent padding values. Row(
modifier = Modifier
.fillMaxWidth()
.padding(
start = MainTheme.spacings.half,
end = MainTheme.spacings.quadruple,
)
.then(modifier),
horizontalArrangement = Arrangement.Center,
verticalAlignment = Alignment.CenterVertically,
) Since the row items are arranged to the center, we can reduce the end padding from This change will provide consistent padding across the app bar while ensuring there’s enough space for the word "Thunderbird." I've searched for other ways to reduce the size, but as far as I know, those options would modify the theme contents and font size, leading to increased complexity. Most common foldable phones have a width of about 2.5 inches, so reducing the padding might help fix the issue. On larger screens, there will still be space after the word "Thunderbird" since the items are centered. I tested this in the preview functionality of Android Studio, as I don't have access to foldable emulators. Can I proceed with this change and create a pull request? |
We could move the title below the icon to give it enough room, the design was optimized for K-9 Mail which is way shorter. Playing with the paddings would collide with the other screens in the onboarding flow and might not work on very small screens. |
We have talked about this internally and decided to
Future improvements could include displaying the text below the icon on very small/narrow screens. However, we don't want this to be the default. |
On more narrow phones like the Fold, the title wraps. I think we should (to an extent) allow the title to shrink so that Thunderbird fits in one line. I'm not sure there is an easy way without forcing the whole text to fit into one line.
The text was updated successfully, but these errors were encountered: